fix(ssh-remote): fallback SSH config parsing and fill-form UX - #1405
Merged
bobleer merged 1 commit intoJul 3, 2026
Merged
Conversation
Add manual ~/.ssh/config parsing when ssh_config crate fails on Include/Match directives, and change config host entries to fill the connection form instead of connecting immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~/.ssh/configparsing fallback when thessh_configcrate fails (e.g.Include/Matchdirectives before the firstHostblock), while still using pattern-matchedquery()results when parsing succeeds.Test plan
~/.ssh/configwithInclude/Matchbefore firstHoststill lists hosts and resolves lookup correctlyHost *settings are applied whenssh_configparsing succeeds